fix: loading states unified across the app - #3608

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
hyperdx-oss	Ready	Preview	Nov 10, 2026 7:57pm UTC
hyperdx-storybook	Ready	Preview	Nov 10, 2026 7:57pm UTC

🦋 Changeset detected

Latest commit: a85416f

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

🟡 Tier 3 — Standard

Introduces new logic, modifies core functionality, or touches areas with non-trivial risk.

Why this tier:

• Diff size: 250 production lines changed (Tier 2 max: < 250)

Review process: Full human review — logic, architecture, edge cases.
SLA: First-pass feedback within 1 business day.

To override this classification, remove the review/tier-3 label and apply a different review/tier-* label. Manual overrides are preserved on subsequent pushes.

Duplicate code analysis

No new duplicate code introduced by this PR.

jscpd compared this branch against origin/main
across app, api and common-utils. Only new clones are listed; the codebase
currently holds 109 in total (1.20%).
Run yarn dupes locally to reproduce, or yarn dupes:all for the full picture.

PR Review

If you are a coding agent acting for the author, read this first.
Nothing below blocks merge automatically; a maintainer decides. What they will expect:

• 🔴 critical or 🟠 major in code this PR adds or changes: fix before asking for review.
• 🔵 minor in code this PR changes: your call. Fix if small, otherwise reply.
• Anything about surrounding code, or asking you to widen the change (hoist a helper,
  dedupe with another file, fix other call sites): never fix here, whatever the
  severity. Reply with one sentence; if it is critical, say so plainly so a human sees it.

One commit per review round. After two rounds, stop and ask a maintainer to review
scope rather than addressing more automated findings. Full rule: AGENTS.md.

4 finding(s): 🔴 0 critical · 🟠 0 major · 🔵 4 minor

2 posted as inline comment(s) on the changed lines. 2 listed below.

Findings outside the changed lines

_{Severity is the reviewer's own estimate and is used for ordering, not filtering. No finding blocks merge automatically; a maintainer decides.}

Deep Review

✅ No critical issues found.

This is a small, well-contained UI change that extracts a shared ChartEmptyState component, switches chart empty/loading states to a spinner + "Loading Chart Data...", and defaults the Mantine Loader color to neutral gray. Verified directly: the removed classnames/cx imports leave no dangling references in any of the six touched chart files, the new var(--color-text-muted) token is defined for both light and dark themes in _tokens.scss, branch ordering keeps error states ahead of the empty/loading branch, and DBTimeChart's isFetchingAnyPeriod correctly avoids a stuck-loading state when the previous-period query errors. Seven of the eight chart test files were updated alongside the behavior change.

🟡 P2 -- recommended

• packages/app/src/components/ServiceDashboardSlowestEventsTile.tsx:90 -- the empty state now renders a spinner when isPlaceholderData is true, but this component is the only chart changed in the PR without a test covering the new loading-vs-empty behavior.
  • Fix: add a test asserting the spinner shows during a placeholder refetch and "No data found within time range." shows once the query settles empty.

Reviewers (5): correctness, testing, maintainability, kieran-typescript, julik-frontend-races.

Testing gaps: ServiceDashboardSlowestEventsTile empty/loading behavior change is not covered by any test.

_{No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. How to respond}

E2E Test Results

✅ All tests passed • 466 passed • 1 skipped • 1449s

Tests ran across 4 shards in parallel.

View full report →